Subject: Testmode arguments

From: amadeus
Date: Sat Mar 11 18:39:50 2006

To: UADE-Developer-discussion
Here are some more suggestions for change of arguments for uade123 =)

I idea behind these suggestions is to have fewer auguments (making the uade123 --help list sorter =) ), and having &quot;postive&quot; arguments rather than &quot;negative*&quot; arguments.

* By negative I mean arguments that starts with &quot;no&quot;, &quot;disable&quot;, or &quot;don't&quot;.

From:
[code:1:45fc130140] -k, --no-keys,      Disable action keys for playback control on terminal
 -K, --keys,         Enable action keys for playback control on terminal
[/code:1:45fc130140]
To:[code:1:45fc130140] -k, --keys=0/1,      Action keys for playback control on terminal.[/code:1:45fc130140]

Just like the
[code:1:45fc130140] --force-led=0/1,    Force LED state to 0 or 1. That is, filter is OFF or ON.
[/code:1:45fc130140]

From:
[code:1:45fc130140]-n, --no-filter     No filter emulation.
[/code:1:45fc130140]
To:
[code:1:45fc130140]--filter=0/1     Filter emulation on/off. Default is on.
[/code:1:45fc130140]
Here I don't think 'n' applies very good, as 'n' used as &quot;no&quot; could be no any argument. Using 'n' for &quot;no song end&quot; could just as well have been the case.

I think 'n' should be used for an argument that starts with 'n', different from no. =)

From:
[code:1:45fc130140]--no-song-end,      Ignore song end report. Just keep playing.
[/code:1:45fc130140]
To:[code:1:45fc130140]Depricated because of
 -w x, --subsong-timeout=x,  Set subsong timeout in seconds. -1 is infinite. Default is 512s

?
[/code:1:45fc130140]

---

From: alankila
Date: Sun Mar 12 09:46:15 2006

To: UADE-Developer-discussion
Note that --filter=xyz is used to set the filtering model. We could roll this option:

-n, --no-filter     No filter emulation. 

into --filter=none which would simply bypass the function that implements the LED filter and the RC rolloff filters.

Other than that, your suggestions seem good to me.

---

From: shd
Date: Sun Mar 12 15:31:07 2006

To: UADE-Developer-discussion
[quote:8994f46b21="amadeus"]Here are some more suggestions for change of arguments for uade123 =)

[/quote:8994f46b21]

Hmm. Good idea. I like changing command line options constantly ;)

[quote:8994f46b21]
From:
[code:1:8994f46b21] -k, --no-keys,      Disable action keys for playback control on terminal
 -K, --keys,         Enable action keys for playback control on terminal
[/code:1:8994f46b21]
To:[code:1:8994f46b21] -k, --keys=0/1,      Action keys for playback control on terminal.[/code:1:8994f46b21]
[/quote:8994f46b21]

Done.

[quote:8994f46b21]
From:
[code:1:8994f46b21]-n, --no-filter     No filter emulation.
[/code:1:8994f46b21]
To:
[code:1:8994f46b21]--filter=0/1     Filter emulation on/off. Default is on.
[/code:1:8994f46b21]
Here I don't think 'n' applies very good, as 'n' used as &quot;no&quot; could be no any argument. Using 'n' for &quot;no song end&quot; could just as well have been the case.

[/quote:8994f46b21]

Done as alankila suggested. --filter=none must be used instead of --no-filter.

[quote:8994f46b21]
From:
[code:1:8994f46b21]--no-song-end,      Ignore song end report. Just keep playing.
[/code:1:8994f46b21]
To:[code:1:8994f46b21]Depricated because of
 -w x, --subsong-timeout=x,  Set subsong timeout in seconds. -1 is infinite. Default is 512s
?
[/code:1:8994f46b21][/quote:8994f46b21]

Infinite timeout is not the same thing as ignoring song end report. Songs with infinite timeout end when the eagleplayer reports song end, but when the report is ignored, the song will just keep playing. Maybe we should have that --no-song-end also sets timeout to infinity.

---

From: amadeus
Date: Sun Mar 12 21:26:52 2006

To: UADE-Developer-discussion
[quote=&quot;shd&quot;]Hmm. Good idea. I like changing command line options constantly ;)
[/code]

Cool! =)

[quote:a36dea9631]Infinite timeout is not the same thing as ignoring song end report. Songs with infinite timeout end when the eagleplayer reports song end, but when the report is ignored, the song will just keep playing. Maybe we should have that --no-song-end also sets timeout to infinity.[/quote:a36dea9631]

I thought uade123 did that already, where uade 1.x only plays for 600 sec.

Eventhough it is actually 2 commands that are required to do &quot;real no song end&quot; I think it is what the users are actually looking for, so I think that timeout should be infinity on --no-song-end

Hmm. What about renaming --no-song-end to -l and --loop ?

---

From: amadeus
Date: Sun Mar 12 21:39:45 2006

To: UADE-Developer-discussion
From latest cvs:
[code:1:6910fdd2be] --filter=model      Set filter model to A500, A500E, A1200, A1200E or NONE.
                     The default is A500E. NONE means disabling filter.
 --filter,           Enable filter emulation. It is enabled by default.
[/code:1:6910fdd2be]

Is the last line needed?

The following uses '/' rather than ',' to seperate arguments
[code:1:6910fdd2be] -d/--debug,         Enable debug mode &#40;expert only&#41;
 -h/--help,          Print help
 -r/--recursive,     Recursive directory scan
[/code:1:6910fdd2be]

---

From: shd
Date: Sun Mar 12 23:37:14 2006

To: UADE-Developer-discussion
[quote:ae2d1085e9="amadeus"]
Hmm. What about renaming --no-song-end to -l and --loop ?[/quote:ae2d1085e9]

Some songs can not be looped, so --loop could be considered buggy with those songs. On the other hand, --no-song-end works always. I'll make --no-song-end to set timeouts to infinity. This is a very seldomly used option so it doesn't need a short switch.

---

From: shd
Date: Mon Mar 13 00:17:23 2006

To: UADE-Developer-discussion
[quote:7160631eeb="amadeus"]From latest cvs:
[code:1:7160631eeb] --filter=model      Set filter model to A500, A500E, A1200, A1200E or NONE.
                     The default is A500E. NONE means disabling filter.
 --filter,           Enable filter emulation. It is enabled by default.
[/code:1:7160631eeb]

Is the last line needed?
[/quote:7160631eeb]

Probably not. The idea is to turn on filtering, but using the filter model  configured in uade.conf.

What do you think about uade.conf? Something to change there?

[quote:7160631eeb]
The following uses '/' rather than ',' to seperate arguments
[code:1:7160631eeb] -d/--debug,         Enable debug mode &#40;expert only&#41;
 -h/--help,          Print help
 -r/--recursive,     Recursive directory scan
[/code:1:7160631eeb][/quote:7160631eeb]

Fixed.

---

From: amadeus
Date: Mon Mar 13 14:29:07 2006

To: UADE-Developer-discussion
[quote:80877e58b4][quote=&quot;shd&quot;][quote:80877e58b4="amadeus"]From latest cvs:
[code:1:80877e58b4] --filter=model      Set filter model to A500, A500E, A1200, A1200E or NONE.
                     The default is A500E. NONE means disabling filter.
 --filter,           Enable filter emulation. It is enabled by default.
[/code:1:80877e58b4]

Is the last line needed?
[/quote:80877e58b4]

Probably not. The idea is to turn on filtering, but using the filter model  configured in uade.conf.[/quote:80877e58b4]

What confuses me is the default value of --filter. By default is it enabled, and --filter also enables filter. Sort of double enabling?

[quote:80877e58b4]What do you think about uade.conf? Something to change there?
[/quote:80877e58b4]

Perhaps the new NONE option should be mentioned by something like
[code:1:80877e58b4]# Set filter emulation mode to be A500, A500E, A1200, A1200E or NONE.
# The default is A500E. NONE means disabling filter.
[/code:1:80877e58b4]
And perhaps depricate
[code:1:80877e58b4]# Turn filter emulation off. You shouldn't use this.
#no_filter
[/code:1:80877e58b4]

There is a small inconsistacy with NONE (from filter) vs. none in
[code:1:80877e58b4]# Set interpolator to default &#40;anti&#41;, anti or none.
#interpolator none
[/code:1:80877e58b4]
Is filter is the only one using upper case arguments?

I really like that examples are givin on commands that are no adviced, but possible! That's freedom! =)

Another config approach is it have all commands present, and rather than writing what is default and what is not recommanded, just setting the options accordinf to that.

The default config files would then become (comments stripped)
[code:1:80877e58b4]filter               A500E
headphone            no
panning              1.0
gain                 0.0
interpolator         none
subsong_timeout      512
action_keys          off
filter               on # converted from no_filter. Deprication in question.
force_led            no # converted from force_led_off
player_check         on # converted from ignore_player_check
one_subsong_per_file no
random_play          off
recursive_mode       off
silence_timeout      0
timeout              0
buffer_time          0
[/code:1:80877e58b4]

Here yes/no/on/off are used in conjunction. Perhaps either on/off or yes/no should be considered?

[quote:80877e58b4]Fixed.[/quote:80877e58b4]
Thanks =)