Subject: ptk-prowiz

From: pieknyman
Date: Mon Aug 29 22:47:41 2005

To: Kohina-UADE-Forum
Unfortunately I still can't use your PTK-Prowiz with Delix since it unpacks mods in the check routine, which makes it impossible to do checking and playing at the same time (bacause of using the same variables I presume). Can the unpacking code be moved to InitPlayer? :)

Cheers!

---

From: shd
Date: Tue Aug 30 07:47:58 2005

To: Kohina-UADE-Forum
[quote:cd42d173ad="pieknyman"]Unfortunately I still can't use your PTK-Prowiz with Delix since it unpacks mods in the check routine, which makes it impossible to do checking and playing at the same time (bacause of using the same variables I presume). Can the unpacking code be moved to InitPlayer? :)
[/quote:cd42d173ad]

I suggest you don't try to do that. Side effects of having simultaneous checks and playing will cause bugs. Anyway, you're right that check() shouldn't unpack mods. Perhaps Michael will do something about it.

---

From: pieknyman
Date: Tue Aug 30 08:01:10 2005

To: Kohina-UADE-Forum
[quote:68ffec44fa="shd"]
I suggest you don't try to do that. Side effects of having simultaneous checks and playing will cause bugs. 
[/quote:68ffec44fa]
I suppose there should be no problems if the checks use only ChkData and ChkSize (that's what these variables exist for). 

[quote:68ffec44fa="shd"]
Anyway, you're right that check() shouldn't unpack mods. Perhaps Michael will do something about it.
[/quote:68ffec44fa]
I'll wait. Thanks.

---

From: mld
Date: Tue Aug 30 13:09:22 2005

To: Kohina-UADE-Forum
I disagree about check shouldn't unpack the mods :) Actually it makes more sense to unpack the mods before accepting them as playable filetype, than in initplayer.

It currently works like this. We get a file and see if they have one of the module tags, if not we pass them on and see if they can be converted to protracker. If both fails, some tests are done to see about some obscure mods without tags like 15 instrument mods. Then we check what kind of mod it is (noise/pro/soundtracker) and then we accept the file.

I can confirm the whole thing is probl. not reentrant because I set some flags for different mod type behaviour *grin* so that's where the trouble probl. comes with delix replaying and checking the same time. I can easily imagine a worst case scenario when accepting and storing a new module pointer while still trying to play from an old pointer. But I think that's not safe with many other replayers too :)

I think about it a bit... :)

---

From: pieknyman
Date: Tue Aug 30 14:39:55 2005

To: Kohina-UADE-Forum
[quote:e5cde2d463="mld"]
I disagree about check shouldn't unpack the mods :) Actually it makes more sense to unpack the mods before accepting them as playable filetype, than in initplayer.
[/quote:e5cde2d463]
Why? InitPlayer can fail, can't it? Check should be as fast as possible, IMO - just examinig wether data at given location is a supported format, returning yes or no and without storing any information. (Of course I don't complain. No. :) )

[quote:e5cde2d463="mld"]
But I think that's not safe with many other replayers too :)
[/quote:e5cde2d463]
Well, Delix is working pretty fine. It looks to me every other player uses chkdata and chksize only and doesn't do anything more. Just look at the sources, if you don't believe me. :)

[quote:e5cde2d463="mld"]
[/quote:e5cde2d463]
Do. :)

---

From: mld
Date: Tue Aug 30 15:00:18 2005

To: Kohina-UADE-Forum
[quote:4724f526e5="pieknyman"][quote:4724f526e5="mld"]
I disagree about check shouldn't unpack the mods :) Actually it makes more sense to unpack the mods before accepting them as playable filetype, than in initplayer.
[/quote:4724f526e5]
Why? InitPlayer can fail, can't it? Check should be as fast as possible, IMO - just examinig wether data at given location is a supported format, returning yes or no and without storing any information. (Of course I don't complain. No. :) )[/quote:4724f526e5]

I agree check should be as fast as possible, but accepting filetypes in check and failing in initplayer doesn't "feel" right.
I can only check mod clones when I depack them before. If I don't store anything I have to depack them again.

[quote:4724f526e5][quote:4724f526e5="mld"]
But I think that's not safe with many other replayers too :)
[/quote:4724f526e5]
Well, Delix is working pretty fine. It looks to me every other player uses chkdata and chksize only and doesn't do anything more. Just look at the sources, if you don't believe me. :)[/quote:4724f526e5]

Luck? hehe, just kidding. I know ptk-prowiz is bad and as I said it's worth to be rewritten, if I only had time... *sigh*

[quote:4724f526e5][quote:4724f526e5="mld"]
I think about it a bit... :)
[/quote:4724f526e5]
Do. :)[/quote:4724f526e5][/quote]

hehe... ok.

---

From: Guest
Date: Tue Aug 30 16:06:23 2005

To: Kohina-UADE-Forum
[quote:8d592f31cd="mld"]
I can only check mod clones when I depack them before. If I don't store anything I have to depack them again.
[/quote:8d592f31cd]
Well, that is some kind od solution. :)

And BTW, your AudioSculpture player is also using GetListData in the check function. :grin:

---

From: pieknyman
Date: Tue Aug 30 16:08:02 2005

To: Kohina-UADE-Forum
Some kind OF solution... (I should have registered to the forum ;) )

---

From: pieknyman
Date: Tue Aug 30 17:12:27 2005

To: Kohina-UADE-Forum
Oh jolly.... Your AudioSculpture player does tricks in the check routine too.... :/